Use non-existing example in tests#20021
Merged
Merged
Conversation
Contributor
Confidence Score: 5/5All changes are confined to test files and are a straight find-and-replace of fixtures; no production code is touched. Every edit is a mechanical rename of test-only identifiers ( No files require special attention. Reviews (1): Last reviewed commit: "use non-existing example" | Re-trigger Greptile |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes a small change to the tests. In some cases, where we test
@utilityfunctionality we usetab-*utilities.But there is a possibility that we will add this as an actual utility, so instead let's use a much more generic
example-*utility. Then we can read from the--exampletheme value, and use--resolved-value: …;and--resolved-modifier: …;values.It's admittedly more vague, but chances of conflicts go way down. Until CSS or Tailwind CSS introduces an
example-*utility...Test plan